Switch back to SimpleDateFormat from DateTimeFormatter and use ThreadLocal to achieve thread safety instead #14753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Local to achieve thread safety instead
gortiz
approved these changes
Jan 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14753 +/- ##
============================================
+ Coverage 61.75% 63.80% +2.05%
- Complexity 207 1608 +1401
============================================
Files 2436 2703 +267
Lines 133233 150737 +17504
Branches 20636 23290 +2654
============================================
+ Hits 82274 96181 +13907
- Misses 44911 47351 +2440
- Partials 6048 7205 +1157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeFormatterwhich isn't backward compatible with the olderSimpleDateFormat. Fix JDBC date time parsing issue #14739 attempted to fix some of the incompatibilities but there will always be some edge cases that aren't covered and it is critical to maintain backward compatibility for clients.SimpleDateFormatbut withThreadLocalinstead to achieve thread safety. This is more expensive since each thread would need to allocate an instance of SDF but is necessary for thread safety and correctness (as can be demonstrated from the tests added earlier).