Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [PoC] Remove Time Series Specific Logic from V1 Engine #14558

Closed
wants to merge 2 commits into from

Conversation

ankitsultana
Copy link
Contributor

While thinking about optimizing TimeSeriesAggregationOperator, one of the approaches I ended up trying was to remove dependence from time series specific code from the V1 Engine. Instead, this PR relies on a new Transform and an Aggregation function that can be run using the existing GroupByOperator and AggregationOperator.

This is a WIP.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0.90090% with 220 lines in your changes missing coverage. Please review.

Project coverage is 34.62%. Comparing base (59551e4) to head (c93c55a).
Report is 1416 commits behind head on master.

Files with missing lines Patch % Lines
...gation/function/TimeSeriesAggregationFunction.java 0.00% 116 Missing ⚠️
...ery/runtime/timeseries/LeafTimeSeriesOperator.java 0.00% 48 Missing ⚠️
...time/timeseries/PhysicalTimeSeriesPlanVisitor.java 0.00% 23 Missing ⚠️
...ransform/function/TimeSeriesTransformFunction.java 0.00% 21 Missing ⚠️
...che/pinot/segment/spi/AggregationFunctionType.java 0.00% 3 Missing ⚠️
...gregation/function/AggregationFunctionFactory.java 0.00% 2 Missing ⚠️
...query/request/context/utils/QueryContextUtils.java 0.00% 1 Missing and 1 partial ⚠️
...untime/timeseries/TimeSeriesPhysicalTableScan.java 0.00% 2 Missing ⚠️
...r/transform/function/TransformFunctionFactory.java 0.00% 1 Missing ⚠️
...va/org/apache/pinot/core/plan/CombinePlanNode.java 0.00% 1 Missing ⚠️
... and 1 more

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (c93c55a). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (59551e4) HEAD (c93c55a)
skip-bytebuffers-false 7 6
unittests 5 3
unittests1 2 0
java-11 5 4
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14558       +/-   ##
=============================================
- Coverage     61.75%   34.62%   -27.13%     
- Complexity      207      779      +572     
=============================================
  Files          2436     2677      +241     
  Lines        133233   147312    +14079     
  Branches      20636    22591     +1955     
=============================================
- Hits          82274    51003    -31271     
- Misses        44911    92180    +47269     
+ Partials       6048     4129     -1919     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 34.61% <0.90%> (-27.10%) ⬇️
java-21 34.61% <0.90%> (-27.02%) ⬇️
skip-bytebuffers-false 34.61% <0.90%> (-27.13%) ⬇️
skip-bytebuffers-true 34.60% <0.90%> (+6.88%) ⬆️
temurin 34.62% <0.90%> (-27.13%) ⬇️
unittests 34.61% <0.90%> (-27.13%) ⬇️
unittests1 ?
unittests2 34.61% <0.90%> (+6.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankitsultana
Copy link
Contributor Author

Closed in favor of #14841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timeseries-engine Tracking tag for generic time-series engine work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants