Modify segment metadata call #14250
Open
Modify segment metadata call #14250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14250 +/- ##
============================================
+ Coverage 61.75% 63.91% +2.16%
- Complexity 207 1608 +1401
============================================
Files 2436 2704 +268
Lines 133233 150979 +17746
Branches 20636 23330 +2694
============================================
+ Hits 82274 96496 +14222
- Misses 44911 47261 +2350
- Partials 6048 7222 +1174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cypherean
force-pushed
the
shreyaa/segment_metadata
branch
4 times, most recently
from
3306b07 to
c489750
Compare
cypherean
force-pushed
the
shreyaa/segment_metadata
branch
5 times, most recently
from
9eec4d1 to
a0d35af
Compare
cypherean
changed the title
Jackie-Jiang
reviewed
Dec 6, 2024
| @Produces(MediaType.APPLICATION_JSON) | ||
| @ApiOperation(value = "Get the server metadata for all table segments", | ||
| notes = "Get the server metadata for all table segments") | ||
| public String getServerSegmentsMetadata( |
There was a problem hiding this comment.
What is the difference between this one and the original one?
There was a problem hiding this comment.
It makes one call per server whereas segments/{tableName}/metadata makes 1 call per segment to fetch the metadata
There was a problem hiding this comment.
Am I mis-reading? Seems this one is exactly the same as the deprecated one
cypherean
force-pushed
the
shreyaa/segment_metadata
branch
from
a0d35af to
5fbbf22
Compare
cypherean
force-pushed
the
shreyaa/segment_metadata
branch
from
3a416fc to
4b2ac8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13990
The fetch segment metadata call for a table makes one call per segment, instead we can have one call per server