Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Init BrokerQueryEventListener #13995

Merged

Conversation

tibrewalpratik17
Copy link
Contributor

During testing of release-1.2, we discovered that our broker query event listener framework was not functioning as expected. When initializing the BrokerQueryEventListener, we call the init method with configurations needed for pushing messages to Kafka and M3. However, after the release, we stopped receiving messages in both systems.

It appears that during the refactoring in #13179, we missed the call to _brokerQueryEventListener.init(config); after creating the listener instance. This PR reintroduces that missing call.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.90%. Comparing base (59551e4) to head (5ad2b78).
Report is 1030 commits behind head on master.

Files with missing lines Patch % Lines
...istener/query/BrokerQueryEventListenerFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13995      +/-   ##
============================================
- Coverage     61.75%   57.90%   -3.85%     
- Complexity      207      219      +12     
============================================
  Files          2436     2612     +176     
  Lines        133233   143194    +9961     
  Branches      20636    21982    +1346     
============================================
+ Hits          82274    82915     +641     
- Misses        44911    53788    +8877     
- Partials       6048     6491     +443     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 57.87% <0.00%> (-3.84%) ⬇️
java-21 57.79% <0.00%> (-3.84%) ⬇️
skip-bytebuffers-false 57.89% <0.00%> (-3.85%) ⬇️
skip-bytebuffers-true 57.76% <0.00%> (+30.04%) ⬆️
temurin 57.90% <0.00%> (-3.85%) ⬇️
unittests 57.89% <0.00%> (-3.85%) ⬇️
unittests1 40.74% <0.00%> (-6.15%) ⬇️
unittests2 27.96% <0.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tibrewalpratik17 tibrewalpratik17 marked this pull request as ready for review September 13, 2024 12:22
@ankitsultana ankitsultana merged commit f546add into apache:master Sep 13, 2024
21 checks passed
@tibrewalpratik17 tibrewalpratik17 deleted the fix_event_listener_init branch September 23, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants