remove file

apache · Oct 2, 2024 · 8ba3594 · 8ba3594
1 parent d03ed38
commit 8ba3594
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 78 deletions.
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java b/pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java
@@ -379,8 +379,9 @@ public int getOptimizedMaxInitialResultHolderCapacity() {
     for (Predicate predicate : predicateColumns) {
       if (predicate.getType() == Predicate.Type.IN || predicate.getType() == Predicate.Type.EQ) {
         ExpressionContext lhs = predicate.getLhs();
-        int size = (predicate.getType() == Predicate.Type.IN) ?
-            ((InPredicate) predicate).getValues().size() : 1;
+        int size = (predicate.getType() == Predicate.Type.IN)
+            ? ((InPredicate) predicate).getValues().size()
+            : 1;
         predicateSizeMap.merge(lhs, size, Integer::sum);
       }
     }

diff --git a/pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMaxGroupByResultHolder.java b/pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkMaxGroupByResultHolder.java
diff --git a/pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java b/pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
@@ -448,6 +448,9 @@ public static class QueryOptionKey {
         // fashion with limited compute.
         public static final String IS_SECONDARY_WORKLOAD = "isSecondaryWorkload";
 
+        // When set to true, the max initial result holder capacity will be optimized based on the query. Rather than
+        // using the default value. This is best-effort for now and returns the default value if the optimization is
+        // not possible.
         public static final String OPTIMIZE_MAX_INITIAL_RESULT_HOLDER_CAPACITY =
             "optimizeMaxInitialResultHolderCapacity";
       }