Skip to content

Commit

Permalink
Cleanup and converge V1 and V2 SchemaConformingTransformer
Browse files Browse the repository at this point in the history
  • Loading branch information
lnbest0707-uber committed Jan 7, 2025
1 parent 82bf63c commit 8173a02
Show file tree
Hide file tree
Showing 11 changed files with 1,649 additions and 2,901 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,11 @@ public class CompositeTransformer implements RecordTransformer {
* </li>
* <li>
* Optional {@link SchemaConformingTransformer} after {@link FilterTransformer}, so that we can transform input
* records that have varying fields to a fixed schema without dropping any fields
* </li>
* <li>
* Optional {@link SchemaConformingTransformerV2} after {@link FilterTransformer}, so that we can transform
* input records that have varying fields to a fixed schema and keep or drop other fields by configuration. We
* records that have varying fields to a fixed schema and keep or drop other fields by configuration. We
* could also gain enhanced text search capabilities from it.
* </li>
* <li>
* {@link DataTypeTransformer} after {@link SchemaConformingTransformer} or {@link SchemaConformingTransformerV2}
* {@link DataTypeTransformer} after {@link SchemaConformingTransformer}
* to convert values to comply with the schema
* </li>
* <li>
Expand Down Expand Up @@ -108,7 +104,6 @@ public static List<RecordTransformer> getDefaultTransformers(TableConfig tableCo
addIfNotNoOp(transformers, new ExpressionTransformer(tableConfig, schema));
addIfNotNoOp(transformers, new FilterTransformer(tableConfig));
addIfNotNoOp(transformers, new SchemaConformingTransformer(tableConfig, schema));
addIfNotNoOp(transformers, new SchemaConformingTransformerV2(tableConfig, schema));
addIfNotNoOp(transformers, new DataTypeTransformer(tableConfig, schema));
addIfNotNoOp(transformers, new TimeValidationTransformer(tableConfig, schema));
addIfNotNoOp(transformers, new SpecialValueTransformer(schema));
Expand Down
Loading

0 comments on commit 8173a02

Please sign in to comment.