diff --git a/.github/workflows/pinot_tests.yml b/.github/workflows/pinot_tests.yml index 93b85c1b15a8..93073e6f4802 100644 --- a/.github/workflows/pinot_tests.yml +++ b/.github/workflows/pinot_tests.yml @@ -58,7 +58,7 @@ jobs: cache: 'maven' - name: Linter Test env: - GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} MAVEN_OPTS: > -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false @@ -112,7 +112,7 @@ jobs: env: RUN_INTEGRATION_TESTS: false RUN_TEST_SET: ${{ matrix.testset }} - GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} MAVEN_OPTS: > -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false @@ -134,7 +134,7 @@ jobs: RUN_INTEGRATION_TESTS: false RUN_TEST_SET: ${{ matrix.testset }} PINOT_OFFHEAP_SKIP_BYTEBUFFER: ${{ matrix.skip_bytebuffer }} - GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} MAVEN_OPTS: > -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false @@ -202,7 +202,7 @@ jobs: - name: Build Project env: RUN_INTEGRATION_TESTS: true - GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} MAVEN_OPTS: > -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false @@ -219,7 +219,7 @@ jobs: RUN_INTEGRATION_TESTS: true RUN_TEST_SET: ${{ matrix.testset }} PINOT_OFFHEAP_SKIP_BYTEBUFFER: ${{ matrix.skip_bytebuffer }} - GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} MAVEN_OPTS: > -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false @@ -245,7 +245,7 @@ jobs: env: RUN_INTEGRATION_TESTS: true RUN_TEST_SET: ${{ matrix.testset }} - GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} MAVEN_OPTS: > -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false @@ -407,7 +407,7 @@ jobs: - uses: actions/cache@v4 env: SEGMENT_DOWNLOAD_TIMEOUT_MINS: 10 - GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} with: path: ~/.m2/repository key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} diff --git a/.gitignore b/.gitignore index 71aa91be6cb9..408b4aa87080 100644 --- a/.gitignore +++ b/.gitignore @@ -56,3 +56,4 @@ kubernetes/helm/**/Chart.lock #Develocity .mvn/.gradle-enterprise/ +.mvn/.develocity/ diff --git a/.mvn/gradle-enterprise.xml b/.mvn/develocity.xml similarity index 69% rename from .mvn/gradle-enterprise.xml rename to .mvn/develocity.xml index cf1a9a0a9e88..8088748653a3 100644 --- a/.mvn/gradle-enterprise.xml +++ b/.mvn/develocity.xml @@ -19,20 +19,19 @@ under the License. --> - + + pinot - https://ge.apache.org + https://develocity.apache.org false - - true - true - true - #{isFalse(env['GITHUB_ACTIONS'])} - ALWAYS - true + + + + + #{{'0.0.0.0'}} @@ -45,4 +44,4 @@ false - + diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml index b7a92d4ebd2e..0836fc47d010 100644 --- a/.mvn/extensions.xml +++ b/.mvn/extensions.xml @@ -22,8 +22,8 @@ com.gradle - gradle-enterprise-maven-extension - 1.20.1 + develocity-maven-extension + 1.22.2 com.gradle diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java index 29cf164f9246..24cd444dc592 100644 --- a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java +++ b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java @@ -141,6 +141,8 @@ public class PinotTaskRestletResource { private static final String TASK_QUEUE_STATE_STOP = "STOP"; private static final String TASK_QUEUE_STATE_RESUME = "RESUME"; + public static final String GENERATION_ERRORS_KEY = "generationErrors"; + public static final String SCHEDULING_ERRORS_KEY = "schedulingErrors"; @Inject PinotHelixTaskResourceManager _pinotHelixTaskResourceManager; @@ -667,8 +669,8 @@ public Map scheduleTasks( schedulingErrors.addAll(value.getSchedulingErrors()); }); } - response.put("generationErrors", String.join(",", generationErrors)); - response.put("schedulingErrors", String.join(",", schedulingErrors)); + response.put(GENERATION_ERRORS_KEY, String.join(",", generationErrors)); + response.put(SCHEDULING_ERRORS_KEY, String.join(",", schedulingErrors)); return response; } diff --git a/pinot-tools/src/main/java/org/apache/pinot/tools/BootstrapTableTool.java b/pinot-tools/src/main/java/org/apache/pinot/tools/BootstrapTableTool.java index 83f6232b95da..7bc803b03e93 100644 --- a/pinot-tools/src/main/java/org/apache/pinot/tools/BootstrapTableTool.java +++ b/pinot-tools/src/main/java/org/apache/pinot/tools/BootstrapTableTool.java @@ -35,6 +35,7 @@ import org.apache.pinot.common.auth.AuthProviderUtils; import org.apache.pinot.common.minion.MinionClient; import org.apache.pinot.common.utils.tls.TlsUtils; +import org.apache.pinot.controller.api.resources.PinotTaskRestletResource; import org.apache.pinot.core.common.MinionConstants; import org.apache.pinot.spi.auth.AuthProvider; import org.apache.pinot.spi.config.table.TableConfig; @@ -308,6 +309,11 @@ private boolean waitForMinionTaskToFinish(Map scheduledTasks, lo try { boolean allCompleted = true; for (String taskType : scheduledTasks.keySet()) { + // ignore the error message entries + if (taskType.equals(PinotTaskRestletResource.GENERATION_ERRORS_KEY) + || taskType.equals(PinotTaskRestletResource.SCHEDULING_ERRORS_KEY)) { + continue; + } String taskName = scheduledTasks.get(taskType); String taskState = _minionClient.getTaskState(taskName); if (!COMPLETED.equalsIgnoreCase(taskState)) {