From 3a2a5835bef9522fa72a2c67f8653f831e673549 Mon Sep 17 00:00:00 2001
From: tibrewalpratik <tibrewalpratik@uber.com>
Date: Tue, 7 Jan 2025 11:45:16 +0100
Subject: [PATCH] Remove default use of outputSegmentMaxSize in
 UpsertCompactMerge task

---
 .../java/org/apache/pinot/core/common/MinionConstants.java | 5 -----
 .../UpsertCompactMergeTaskGenerator.java                   | 7 ++++---
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java b/pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java
index 24db1f9ede3c..9fef661075b0 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java
@@ -287,11 +287,6 @@ public static class UpsertCompactMergeTask {
      */
     public static final String OUTPUT_SEGMENT_MAX_SIZE_KEY = "outputSegmentMaxSize";
 
-    /**
-     * default output segment size
-     */
-    public static final String DEFAULT_OUTPUT_SEGMENT_MAX_SIZE = "200MB";
-
     /**
      * default maximum number of segments to process in a single task
      */
diff --git a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java
index dd7bf283532a..6ed13612993f 100644
--- a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java
+++ b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java
@@ -248,9 +248,10 @@ public static SegmentSelectionResult processValidDocIdsMetadata(Map<String, Stri
     // default to Long.MAX_VALUE to avoid size-based compaction by default
     long outputSegmentMaxSizeInBytes = Long.MAX_VALUE;
     try {
-      outputSegmentMaxSizeInBytes = DataSizeUtils.toBytes(
-          taskConfigs.getOrDefault(MinionConstants.UpsertCompactMergeTask.OUTPUT_SEGMENT_MAX_SIZE_KEY,
-              MinionConstants.UpsertCompactMergeTask.DEFAULT_OUTPUT_SEGMENT_MAX_SIZE));
+      if (taskConfigs.containsKey(MinionConstants.UpsertCompactMergeTask.OUTPUT_SEGMENT_MAX_SIZE_KEY)) {
+        outputSegmentMaxSizeInBytes =
+            DataSizeUtils.toBytes(taskConfigs.get(MinionConstants.UpsertCompactMergeTask.OUTPUT_SEGMENT_MAX_SIZE_KEY));
+      }
     } catch (Exception e) {
       LOGGER.warn("Invalid value for outputSegmentMaxSizeInBytes, defaulting to Long.MAX_VALUE", e);
     }