Remove default use of outputSegmentMaxSize in UpsertCompactMerge task

apache · Jan 7, 2025 · 3a2a583 · 3a2a583
1 parent 4588f8c
commit 3a2a583
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java b/pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java
@@ -287,11 +287,6 @@ public static class UpsertCompactMergeTask {
      */
     public static final String OUTPUT_SEGMENT_MAX_SIZE_KEY = "outputSegmentMaxSize";
 
-    /**
-     * default output segment size
-     */
-    public static final String DEFAULT_OUTPUT_SEGMENT_MAX_SIZE = "200MB";
-
     /**
      * default maximum number of segments to process in a single task
      */

diff --git a/.../apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java b/.../apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java
@@ -248,9 +248,10 @@ public static SegmentSelectionResult processValidDocIdsMetadata(Map<String, Stri
     // default to Long.MAX_VALUE to avoid size-based compaction by default
     long outputSegmentMaxSizeInBytes = Long.MAX_VALUE;
     try {
-      outputSegmentMaxSizeInBytes = DataSizeUtils.toBytes(
-          taskConfigs.getOrDefault(MinionConstants.UpsertCompactMergeTask.OUTPUT_SEGMENT_MAX_SIZE_KEY,
-              MinionConstants.UpsertCompactMergeTask.DEFAULT_OUTPUT_SEGMENT_MAX_SIZE));
+      if (taskConfigs.containsKey(MinionConstants.UpsertCompactMergeTask.OUTPUT_SEGMENT_MAX_SIZE_KEY)) {
+        outputSegmentMaxSizeInBytes =
+            DataSizeUtils.toBytes(taskConfigs.get(MinionConstants.UpsertCompactMergeTask.OUTPUT_SEGMENT_MAX_SIZE_KEY));
+      }
     } catch (Exception e) {
       LOGGER.warn("Invalid value for outputSegmentMaxSizeInBytes, defaulting to Long.MAX_VALUE", e);
     }