Add check to query generator ensuring that BETWEEN on numerical liter…

…als has correct ordering since returned result table will be empty otherwise
apache · Oct 4, 2024 · 0975b60 · 0975b60
1 parent 4825c2c
commit 0975b60
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/...ntegration-test-base/src/test/java/org/apache/pinot/integration/tests/QueryGenerator.java b/...ntegration-test-base/src/test/java/org/apache/pinot/integration/tests/QueryGenerator.java
@@ -1005,6 +1005,16 @@ public QueryFragment generatePredicate(String columnName, boolean useMultistageE
       List<String> columnValues = _columnToValueList.get(columnName);
       String leftValue = pickRandom(columnValues);
       String rightValue = pickRandom(columnValues);
+
+      if (_singleValueNumericalColumnNames.contains(columnName)) {
+        // For numerical columns, make sure leftValue < rightValue.
+        if (Double.parseDouble(leftValue) > Double.parseDouble(rightValue)) {
+          String temp = leftValue;
+          leftValue = rightValue;
+          rightValue = temp;
+        }
+      }
+
       return new StringQueryFragment(
           String.format("%s BETWEEN %s AND %s", columnName, leftValue, rightValue),
           String.format("`%s` BETWEEN %s AND %s", columnName, leftValue, rightValue));