Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect 1.0.x branch #325

Merged
merged 1 commit into from
Jan 27, 2024
Merged

protect 1.0.x branch #325

merged 1 commit into from
Jan 27, 2024

Conversation

pjfanning
Copy link
Contributor

also updates job for 1.0 doc publishing to use v1.0.2 (latest release)

@pjfanning pjfanning marked this pull request as draft January 25, 2024 11:51
@mdedetrich
Copy link
Contributor

@pjfanning One PR that is relevant for 1.0.x just landed in main, can you rebase? Otherwise we have to a cherry pick of a commit

@pjfanning
Copy link
Contributor Author

I'll delay adding this and will be rebase 1.0.x - the PR that I want to merge now is #326

@pjfanning pjfanning marked this pull request as ready for review January 26, 2024 11:35
@mdedetrich
Copy link
Contributor

CI seems to be failing for some reason?

@pjfanning
Copy link
Contributor Author

CI seems to be failing for some reason?

Worked when I rebuilt. The issue appears that the mima checks ran while the 1.0.2 jars were partially copied into maven central.

@pjfanning
Copy link
Contributor Author

@mdedetrich could you re-review?

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 7ca571c into apache:main Jan 27, 2024
49 of 50 checks passed
@pjfanning pjfanning deleted the 1.0.x-branch branch January 27, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants