Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepend package name for Record class #295

Merged
merged 2 commits into from
Dec 23, 2023
Merged

prepend package name for Record class #295

merged 2 commits into from
Dec 23, 2023

Conversation

pjfanning
Copy link
Contributor

clashes with java.lang.Record

causes compile issues if you build with JDK >= 14

mdedetrich
mdedetrich approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm although its cleaner to just use an import alias i.e.

import software.amazon.awssdk.services.kinesis.model.{Record => KRecord}

@pjfanning pjfanning force-pushed the java-17-compile-issue branch from 93384b3 to 04418d4 Compare December 23, 2023 23:13
@pjfanning
Copy link
Contributor Author

lgtm although its cleaner to just use an import alias i.e.

import software.amazon.awssdk.services.kinesis.model.{Record => KRecord}

this is a Java file though

@pjfanning pjfanning merged commit 0bc0b9e into apache:main Dec 23, 2023
49 of 50 checks passed
@pjfanning pjfanning deleted the java-17-compile-issue branch December 23, 2023 23:32
@mdedetrich
Copy link
Contributor

this is a Java file though

Woops missed this, nw then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @mdedetrich