-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-9572. Restore favicons from original ozone website #51
HDDS-9572. Restore favicons from original ozone website #51
Conversation
Restored favicons from original size. Pointed to new location in docusaurus config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @makinyemi, I'm not too familiar with it, but I think in this patch only the favicon.ico
is actually used, none of the other files that you added in static/img
is used anywhere in the code. Does it get picked up somehow? I tried your changes locally and I removed everything, except static/img/favicon.ico
and the change in docusaurus.config.js
, where you are adding the favicon. In the browser the favicon was still there. I also tried checking the Docusaurus documentation, it seems only one file can be added there, so it's different from the approach in the current site, that was done here. What do you think?
@dombizita correct, the other images are not used in this patch. My assumption was they would be used in some future patch so my thought was to add all the previous existing favicons from the current site in this patch.
I had updated the |
Hi @makinyemi thanks for working on this. Turns out this is tricky to get right and after spending the better part of a day on it this is what I came up with:
I have all of this on this branch of my fork. I tested it using this chrome extension on the local website preview. If it looks good I can either push it to this PR or open a new PR. References: |
Actually it looks like docusaurus has a PWA plugin. We should probably use this to set up everything except the main .ico favicon and svg favicon. |
I've taken another stab at this in #95 |
Since #95 is merged, I'm going to close this for now. If there are other improvements to favicons we want to do we can do them in a follow up PR. |
This PR adds favicons from original site, and update docusaurus.config.js to point to the location of the new favicon