-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-11938. [Website v2] [Docs] [Quick Start] Try Ozone With Kubernetes #116
base: HDDS-9225-website-v2
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Eric977 for working on this.
In the old docs, Kubernetes topic is split to two pages:
I think we should import both to this single page. The PR is now importing only the second item, but the text references the first one ("Minikube deployment"). As a reader, I wouldn't know what that is. Not sure what would be the best heading for current content. (Does "Hosted Cluster" make sense?)
I also think we need to improve the text in follow-up task(s). As a start, it's best to import it as-is. However, we should make some trivial fixes, like changing "the dockerhub" to "Docker Hub". This makes it unnecessary to define "dockerhub" as a word (it is not).
Thank you for your feedback! I've addressed the missing pages and added them to the migration. Regarding the heading, I’ve applied the suggested change to 'Hosted Cluster.' Do you think 'Hosted Kubernetes Cluster' might be clearer? |
Thanks for the updates.
Yes, that may be better. |
I would like avoid importing unfinished content into the new website, it will be hard to track and we will just accumulate debt on an already new project. Remember we are going to have 200-300 pages worth of docs. As part of testing for this PR, please try out the steps locally to verify that they are clear and working. |
the command To resolve this issue, replace the command with: The issue and its solution are discussed in detail in this GitHub issue. Currently, I am testing the documentation in my local environment (wsl on window) and have encountered some additional issues. It seems that the latest release (1.4.1) has no corresponding Docker image, which results in pod initialization failures. After switching to version 1.4.0, I encounter the following error and am still investigating:
|
Thank you for spotting this. Recently we switched to Rocky Linux, and published new images for existing versions with tags like |
Docker Image |
Thanks for your help
The issue was due to a misconfiguration in my Kubernetes storage. After fixing it, everything started running correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @Eric977
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> | ||
|
||
# Try Ozone With Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a quick summary here about the options for deploying Ozone with K8s and the info that will follow. This will also be automatically picked up in the doc card summary seen here
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what our approach to license headers on markdown should be.
- The ASF policy seems to imply it is only required if we are shipping these pages with a release, which we are not currently.
- The ASF website itself does not have headers on their page source
- The default skywalking eyes config which is set up for apache projects does not check markdown files and ours does not either.
- Adding the header in this way will cause this issue in docusaurus. If we need it we would probably have to put it as comments in the yaml front matter.
None of the current markdown pages have headers so I'm thinking we keep going in that direction but I can't find conclusive evidence saying they aren't required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think license is included in the original docs in apache/ozone
since they are part of the official source release. But the website is not "released", so we can remove the license header.
**Requirements:** | ||
|
||
* Working minikube setup | ||
* kubectl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use -
for unordered lists since it is consistent with the existing pages in the new site. This was supposed to be enforced by markdownlint but I made a mistake in the config. I'll push a fix for the markdownlint config soon.
Opening kubernetes service default/s3g-public in default browser... | ||
``` | ||
|
||
## Hosted Kubernetes Cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting suggestions above also apply to this section
``` bash | ||
kubectl port-forward s3g-0 9878:9878 | ||
kubectl port-forward scm-0 9876:9876 | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point here we should run ozone version
in a pod as part of the test that things were set up correctly. More thorough testing will be done in the following "Reading and Writing Data" section.
Co-authored-by: Ethan Rose <33912936+errose28@users.noreply.github.com>
Co-authored-by: Ethan Rose <33912936+errose28@users.noreply.github.com>
Co-authored-by: Ethan Rose <33912936+errose28@users.noreply.github.com>
Co-authored-by: Ethan Rose <33912936+errose28@users.noreply.github.com>
Co-authored-by: Ethan Rose <33912936+errose28@users.noreply.github.com>
Hi @errose28 Thanks for the review, and sorry for the mistakes. I have fixed the comments above. |
What changes were proposed in this pull request?
HDDS-11938. [Website v2] [Docs] [Quick Start] Try Ozone With Kubernetes
Please describe your PR in detail:
Migrate doc from https://ozone.apache.org/docs/edge/start/kubernetes.html to https://ozone-site-v2.staged.apache.org/docs/quick-start/installation/kubernetes
What is the link to the Apache Jira?
https://issues.apache.org/jira/browse/HDDS-11938
How was this patch tested?
Previewed locally.