Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11263. Announce release 1.4.1 on the website #107

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

xichen01
Copy link
Contributor

What changes were proposed in this pull request?

Add release page for Ozone 1.4.1 release to the master branch.

What is the link to the Apache Jira?

https://issues.apache.org/jira/browse/HDDS-11263

@adoroszlai adoroszlai changed the title HDDS-11263. Update latest version on main page HDDS-11263. Announce release 1.4.1 on the website Nov 24, 2024
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xichen01 for creating a new PR. I have some minor suggestions. Let's wait for others to review, too.

Comment on lines 20 to 21
![Hot-Springs-haiku](releases/1.4.0.jpg)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can omit the same image.

Suggested change
![Hot-Springs-haiku](releases/1.4.0.jpg)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically, this nature park is also a park tag of ozone-1.4.1, which is an independent release version, so should we remove this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, but you can wait for other opinions before updating the patch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in the new website proposal I don't like the whole National Park Haiku thing 😄 I'm totally ok with dropping it here.

Comment on lines 27 to 33


Image credit: [Hot Springs Mountain Tower][image] by [Jeremy Thompson][author], [CC BY 2.0][cc] / Text added to original

[image]: https://www.flickr.com/photos/rollercoasterphilosophy/52894005148
[author]: https://www.flickr.com/photos/rollercoasterphilosophy/
[cc]: https://creativecommons.org/licenses/by/2.0/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Image credit: [Hot Springs Mountain Tower][image] by [Jeremy Thompson][author], [CC BY 2.0][cc] / Text added to original
[image]: https://www.flickr.com/photos/rollercoasterphilosophy/52894005148
[author]: https://www.flickr.com/photos/rollercoasterphilosophy/
[cc]: https://creativecommons.org/licenses/by/2.0/

Comment on lines 24 to 26

This is a generally available (GA) release.
It represents a point of API stability and quality that we consider production-ready.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep repeating this?

Comment on lines 22 to 23
Apache Ozone 1.4.1 is a minor bug fix release. Compared to Ozone 1.4.0,
this version resolves some bugs to improve stability and reliability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to include a link to the list of commits and/or Jira issues resolved in 1.4.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag ozone-1.4.1 has been pushed, I will add this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for a Jira link as well.

@adoroszlai adoroszlai requested a review from errose28 November 24, 2024 15:43
@xichen01
Copy link
Contributor Author

@adoroszlai I have removed some duplicate contents and improved release description.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xichen01, I think it's much better.

@xichen01
Copy link
Contributor Author

Thanks @errose28, @adoroszlai for the review.

@xichen01 xichen01 merged commit eb5fd2d into apache:master Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants