Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11834. Test chart on push events #12

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Helm chart test workflow is triggered only on pull requests. It should be triggered for push events, too, so that developers can get feedback in their fork before opening PR.

https://issues.apache.org/jira/browse/HDDS-11834

How was this patch tested?

pull_request run:
https://github.com/adoroszlai/ozone-helm-charts/actions/runs/12115358222/job/33773561272

push run:
https://github.com/adoroszlai/ozone-helm-charts/actions/runs/12115357849/job/33773560328

@adoroszlai adoroszlai self-assigned this Dec 2, 2024
Copy link
Contributor

@dnskr dnskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very reasonable change.

@adoroszlai adoroszlai merged commit 5b5e67b into apache:main Dec 2, 2024
1 check passed
@adoroszlai adoroszlai deleted the HDDS-11834 branch December 2, 2024 19:44
@adoroszlai
Copy link
Contributor Author

Thanks @dnskr for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants