Skip to content

fix: remove unused deps in core #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove unused deps in core #6075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 0 additions & 136 deletions core/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 2 additions & 8 deletions core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ services-gcs = [
services-gdrive = ["internal-path-cache"]
services-ghac = ["dep:ghac", "dep:prost", "services-azblob"]
services-github = []
services-gridfs = ["dep:mongodb", "dep:mongodb-internal-macros"]
services-gridfs = ["dep:mongodb"]
services-hdfs = ["dep:hdrs"]
services-hdfs-native = ["hdfs-native"]
services-http = []
Expand All @@ -168,7 +168,7 @@ services-memcached = ["dep:bb8"]
services-memory = []
services-mini-moka = ["dep:mini-moka"]
services-moka = ["dep:moka"]
services-mongodb = ["dep:mongodb", "dep:mongodb-internal-macros"]
services-mongodb = ["dep:mongodb"]
services-monoiofs = ["dep:monoio", "dep:flume"]
services-mysql = ["dep:sqlx", "sqlx?/mysql"]
services-nebula-graph = ["dep:rust-nebula", "dep:bb8", "dep:snowflaked"]
Expand Down Expand Up @@ -312,7 +312,6 @@ mini-moka = { version = "0.10", optional = true }
moka = { version = "0.12", optional = true, features = ["future", "sync"] }
# for services-mongodb
mongodb = { version = "3.2.2", optional = true }
mongodb-internal-macros = { version = "3.2.2", optional = true }
# for services-sftp
openssh = { version = "0.11.0", optional = true }
openssh-sftp-client = { version = "0.15.2", optional = true, features = [
Expand Down Expand Up @@ -414,23 +413,18 @@ tokio = { version = "1.27", features = ["time"] }
uuid = { version = "1.14", features = ["serde", "v4", "js"] }

[dev-dependencies]
criterion = { version = "0.5", features = ["async", "async_tokio"] }
divan = { version = "0.1" }
dotenvy = "0.15"
fastrace = { version = "0.7", features = ["enable"] }
fastrace-jaeger = "0.7"
libtest-mimic = "0.8"
opentelemetry = { version = "0.29.0", default-features = false, features = [
"trace",
] }
opentelemetry-otlp = { version = "0.29.0", features = ["grpc-tonic"] }
opentelemetry_sdk = { version = "0.29.0", features = ["rt-tokio"] }
Comment on lines -426 to -427
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this is needed for tracing

Copy link
Contributor Author

@JackDrogon JackDrogon Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no releated code(just commentted example code use it) use it, if u need, u just import it in high level crate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doctest is marked as no_run, but run in ci🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew, no_run mark just let ci not run the code, but compile it. I will fix it

pretty_assertions = "1"
rand = "0.8"
sha2 = "0.10"
size = "0.4"
tokio = { version = "1.27", features = ["fs", "macros", "rt-multi-thread"] }
tracing-opentelemetry = "0.30.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

tracing-subscriber = { version = "0.3", features = [
"env-filter",
"tracing-log",
Expand Down
1 change: 0 additions & 1 deletion core/edge/file_write_on_full_disk/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ rust-version.workspace = true
version.workspace = true

[dependencies]
futures = "0.3"
opendal = { path = "../..", features = ["services-memory", "services-fs"] }
rand = "0.8"
tokio = { version = "1", features = ["full"] }
1 change: 0 additions & 1 deletion core/edge/s3_read_on_wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ opendal = { path = "../..", default-features = false, features = [
"services-s3",
] }
wasm-bindgen = "0.2.89"
wasm-bindgen-futures = "0.4.39"

[dev-dependencies]
wasm-bindgen-test = "0.3.41"
1 change: 0 additions & 1 deletion core/examples/basic/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,5 @@ rust-version.workspace = true
version.workspace = true

[dependencies]
futures = "0.3"
opendal = { path = "../..", features = ["tests"] }
tokio = { version = "1.38.0", features = ["macros", "rt-multi-thread"] }
1 change: 0 additions & 1 deletion core/examples/concurrent-upload/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,5 @@ rust-version.workspace = true
version.workspace = true

[dependencies]
futures = "0.3"
opendal = { path = "../..", features = ["tests"] }
tokio = { version = "1.38.0", features = ["macros", "rt-multi-thread"] }
1 change: 0 additions & 1 deletion core/examples/multipart-upload/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,5 @@ rust-version.workspace = true
version.workspace = true

[dependencies]
futures = "0.3"
opendal = { path = "../..", features = ["tests"] }
tokio = { version = "1.38.0", features = ["macros", "rt-multi-thread"] }
Loading