fix: remove unused deps in core #6075
Open
+2
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
dosubot
bot
added
size:S
yihong0618
reviewed
Apr 22, 2025
Comment on lines
-426
to
-427
| opentelemetry-otlp = { version = "0.29.0", features = ["grpc-tonic"] } | ||
| opentelemetry_sdk = { version = "0.29.0", features = ["rt-tokio"] } |
There was a problem hiding this comment.
maybe this is needed for tracing
There was a problem hiding this comment.
no releated code(just commentted example code use it) use it, if u need, u just import it in high level crate.
There was a problem hiding this comment.
the doctest is marked as no_run, but run in ci🤔
There was a problem hiding this comment.
I knew, no_run mark just let ci not run the code, but compile it. I will fix it
| pretty_assertions = "1" | ||
| rand = "0.8" | ||
| sha2 = "0.10" | ||
| size = "0.4" | ||
| tokio = { version = "1.27", features = ["fs", "macros", "rt-multi-thread"] } | ||
| tracing-opentelemetry = "0.30.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
remove unused deps in core