use small lock to protect g_ram_vectors, involving armv6-m, armv7-m, …

…armv8-m. Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
apache · Jan 10, 2025 · 37cd0a1 · 37cd0a1
1 parent 0694de1
commit 37cd0a1
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 6 deletions.
diff --git a/arch/arm/src/armv6-m/arm_ramvec_attach.c b/arch/arm/src/armv6-m/arm_ramvec_attach.c
@@ -31,11 +31,18 @@
 
 #include <nuttx/irq.h>
 #include <nuttx/arch.h>
+#include <nuttx/spinlock.h>
 
 #include "ram_vectors.h"
 
 #ifdef CONFIG_ARCH_RAMVECTORS
 
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static spinlock_t g_ramvec_lock = SP_UNLOCKED;
+
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -68,7 +75,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector)
        * common exception handler.
        */
 
-      flags = enter_critical_section();
+      flags = spin_lock_irqsave(&g_ramvec_lock);
       if (vector == NULL)
         {
           /* Disable the interrupt if we can before detaching it.  We might
@@ -87,7 +94,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector)
       /* Save the new vector in the vector table */
 
       g_ram_vectors[irq] = vector;
-      leave_critical_section(flags);
+      spin_unlock_irqrestore(&g_ramvec_lock, flags);
       ret = OK;
     }
 

diff --git a/arch/arm/src/armv7-m/arm_ramvec_attach.c b/arch/arm/src/armv7-m/arm_ramvec_attach.c
@@ -31,11 +31,18 @@
 
 #include <nuttx/irq.h>
 #include <nuttx/arch.h>
+#include <nuttx/spinlock.h>
 
 #include "ram_vectors.h"
 
 #ifdef CONFIG_ARCH_RAMVECTORS
 
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static spinlock_t g_ramvec_lock = SP_UNLOCKED;
+
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -68,7 +75,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector)
        * common exception handler.
        */
 
-      flags = enter_critical_section();
+      flags = spin_lock_irqsave(&g_ramvec_lock);
       if (vector == NULL)
         {
           /* Disable the interrupt if we can before detaching it.  We might
@@ -87,7 +94,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector)
       /* Save the new vector in the vector table */
 
       g_ram_vectors[irq] = vector;
-      leave_critical_section(flags);
+      spin_unlock_irqrestore(&g_ramvec_lock, flags);
       ret = OK;
     }
 

diff --git a/arch/arm/src/armv8-m/arm_ramvec_attach.c b/arch/arm/src/armv8-m/arm_ramvec_attach.c
@@ -31,11 +31,18 @@
 
 #include <nuttx/irq.h>
 #include <nuttx/arch.h>
+#include <nuttx/spinlock.h>
 
 #include "ram_vectors.h"
 
 #ifdef CONFIG_ARCH_RAMVECTORS
 
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static spinlock_t g_ramvec_lock = SP_UNLOCKED;
+
 /****************************************************************************
  * Public Functions
  ****************************************************************************/
@@ -68,7 +75,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector)
        * common exception handler.
        */
 
-      flags = enter_critical_section();
+      flags = spin_lock_irqsave(&g_ramvec_lock);
       if (vector == NULL)
         {
           /* Disable the interrupt if we can before detaching it.  We might
@@ -87,7 +94,7 @@ int arm_ramvec_attach(int irq, up_vector_t vector)
       /* Save the new vector in the vector table */
 
       g_ram_vectors[irq] = vector;
-      leave_critical_section(flags);
+      spin_unlock_irqrestore(&g_ramvec_lock, flags);
       ret = OK;
     }