crypto/mbedtls: Upgrade to v3.6.2 #3401
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now -DMBEDTLS_USER_CONFIG_FILE=<mbedtls/config_mynewt.h> flag is used globally for each build that depends on mbedtls package. This way we won't have to add this flag in each package that uses mbedtls.
This adds unit test for additional mynewt GCM related APIs
This upgrades mbedtls version to v3.62:
1. mbedtls repository changed to version v3.6.2
2. Removed tests that are no longer supported
3. Updated/modified gcm_mynewt API:
a) Function mbedtls_gcm_update_add is removed, because now
function mbedtls_gcm_update_ad from mbedtls upstream
provides the same functionality.
b) Due to internal mbedtls API changes mbedtls_gcm_setkey_noalloc
function now needs one argument more, which is keybits.
This argument specifies length of key in bits and should
be set to 128, 192 or 256. Other values won't be accepted.
In earlier version this could be extracted from
mbedtls_cipher_info_t key_bitlen field, which is no longer
the case - now it's 4 bit bitfield later processed by
internal mbedtls macros.
It probably would be possible to not break this APIs, but
since a lot of mbedtls APIs where changed in new version
it was assumed that migration changes in projects using mbedtls
would be necessary anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades mbedtls version to v3.62:
a) Function mbedtls_gcm_update_add is removed, because now
function mbedtls_gcm_update_ad from mbedtls upstream
provides the same functionality.
b) Due to internal mbedtls API changes mbedtls_gcm_setkey_noalloc
function now needs one argument more, which is keybits.
This argument specifies length of key in bits and should
be set to 128, 192 or 256. Other values won't be accepted.
In earlier version this could be extracted from
mbedtls_cipher_info_t key_bitlen field, which is no longer
the case - now it's 4 bit bitfield later processed by
internal mbedtls macros.
It probably would be possible to not break this APIs, but
since a lot of mbedtls APIs where changed in new version
it was assumed that migration changes in projects using mbedtls
would be necessary anyway.