Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene.Net.Util.PriorityQueue: Removed [Serializable] attribute. #876

Conversation

NightOwl888
Copy link
Contributor

Binary serialization is obsolete in .NET 6+, and serialization didn't technically support extension because it was missing the virtual GetObjectData and OnDeserialization methods and deserialization constructor.

This fixes the SonarCloud security hotspot Deserializing objects without performing data validation is security-sensitive.

…ry serialization is obsolete in .NET 6+, and serialization didn't technically support extension anyway because it was missing the virtual GetObjectData and OnDeserialization methods and deserialization constructor.
@NightOwl888 NightOwl888 merged commit b8aabe3 into apache:master Oct 19, 2023
197 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant