IDisposable Pattern Cleanup and fix TestDictionary.TestResourceCleanup, #265 #1095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor cleanup of IDisposable pattern implementations, and a bug fix.
Fixes #265
Description
I did a review of all implementations of
IDisposable.Dispose()
to ensure they follow the Dispose Pattern correctly, and someone had clearly already done all of the hard work here: it was nearly all done right. There were a couple cases that I fixed in this PR:sealed
.this.disposed
in the actual Dispose pattern override method so that it's properly marked when called virtually, and leaving the stream open in the Dictionary.ReadDictionaryFiles method to match Java's behavior (and the expected behavior per the unit test).