-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Lucene volatile long/double values to Atomic counterparts, #1063 #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NightOwl888
requested changes
Dec 13, 2024
NightOwl888
requested changes
Dec 14, 2024
…l variable names to reflect AtomicDouble rather than AtomicInt64
NightOwl888
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple more minor issues with parameter/variable naming and the fact that TryFormat
wasn't overridden and pushed a couple of commits. I have opened NightOwl888/J2N#125 and NightOwl888/J2N#126 to address some of the issues that were discovered here in J2N.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert long/double values that are volatile in Lucene (but can't be in .NET) to AtomicInt64 or (new) AtomicDouble.
Fixes #1063
Description
Since we can't use
volatile
on 64-bit values in .NET, this doesn't work forlong
ordouble
. This PR changesvolatile long
fields to beAtomicInt64
from J2N, as well as introduces a new internalAtomicDouble
type in Support for those values, using bit conversion to/from long internally so that we can use Interlocked on it.