Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to empty blocks to address Sonar csharpsquid:S108, #672 #1032

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Add comments to empty blocks to address Sonar csharpsquid:S108

Fixes #672

Description

Sonar was finding empty blocks (while, using, for, catch, etc.) that did not have any statements in them nor comments, so this adds comments since in almost all cases it was intended to be ignored. In one case, the code was changed to better match upstream by manually calling Dispose instead of using a using block.

@paulirwin paulirwin added the notes:ignore Don't show this PR in the Release Notes label Nov 19, 2024
@paulirwin paulirwin merged commit 3c14b14 into apache:master Nov 19, 2024
199 checks passed
@paulirwin paulirwin deleted the issue/672 branch November 19, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:ignore Don't show this PR in the Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Either remove or fill this block of code
1 participant