From 2d68abc25dd77a69926b16234510377c9b63acad Mon Sep 17 00:00:00 2001 From: Grzegorz Dziadkiewicz Date: Fri, 15 Nov 2024 08:45:11 +0100 Subject: [PATCH] Turn on the CI build for PRs (#204) * Divide steps * Try the approach from build doc * Add PR trigger * Fix branch name * Try dotnet build & test * Enable quackers * Remove Zarro from the CI build --- .github/workflows/build.yaml | 26 ++++++++++++++------------ src/log4net.Tests/log4net.Tests.csproj | 1 + 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index a6d3241d..c5ea637f 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -19,6 +19,10 @@ name: build on: workflow_dispatch: + push: + branches: + - master + pull_request: jobs: @@ -31,6 +35,10 @@ jobs: matrix: os: [ macos-latest, ubuntu-latest, windows-latest ] + env: + DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 + DOTNET_CLI_TELEMETRY_OPTOUT: 1 + steps: - name: Checkout repository @@ -42,16 +50,10 @@ jobs: dotnet-version: 8 dotnet-quality: ga - - name: Set up NodeJs - uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # 4.0.3 - with: - node-version: 20 - - - name: Build and test - env: - DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 - DOTNET_CLIE_TELEMETRY_OPTOUT: 1 + - name: Build + run: | + dotnet build ./src/log4net.sln + + - name: Test run: | - npm update -g npm --no-progress - npm install --no-progress - npm test + dotnet test ./src/log4net.sln diff --git a/src/log4net.Tests/log4net.Tests.csproj b/src/log4net.Tests/log4net.Tests.csproj index 318518d1..8670c967 100644 --- a/src/log4net.Tests/log4net.Tests.csproj +++ b/src/log4net.Tests/log4net.Tests.csproj @@ -12,6 +12,7 @@ TRACE;DEBUG;$(DefineConstants) CS8032 + quackers