Skip to content

Commit

Permalink
Turn on the CI build for PRs (#204)
Browse files Browse the repository at this point in the history
* Divide steps
* Try the approach from build doc
* Add PR trigger
* Fix branch name
* Try dotnet build & test
* Enable quackers
* Remove Zarro from the CI build
  • Loading branch information
gdziadkiewicz authored Nov 15, 2024
1 parent 0f8b41c commit 2d68abc
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 12 deletions.
26 changes: 14 additions & 12 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ name: build

on:
workflow_dispatch:
push:
branches:
- master
pull_request:

jobs:

Expand All @@ -31,6 +35,10 @@ jobs:
matrix:
os: [ macos-latest, ubuntu-latest, windows-latest ]

env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1

steps:

- name: Checkout repository
Expand All @@ -42,16 +50,10 @@ jobs:
dotnet-version: 8
dotnet-quality: ga

- name: Set up NodeJs
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # 4.0.3
with:
node-version: 20

- name: Build and test
env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLIE_TELEMETRY_OPTOUT: 1
- name: Build
run: |
dotnet build ./src/log4net.sln
- name: Test
run: |
npm update -g npm --no-progress
npm install --no-progress
npm test
dotnet test ./src/log4net.sln
1 change: 1 addition & 0 deletions src/log4net.Tests/log4net.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<DefineConstants>TRACE;DEBUG;$(DefineConstants)</DefineConstants>
<!-- suppress analyzer mismatch warning -->
<NoWarn>CS8032</NoWarn>
<VSTestLogger>quackers</VSTestLogger>
</PropertyGroup>
<ItemGroup>
<Compile Include="..\log4net\Diagnostics\CodeAnalysis\CallerArgumentExpressionAttribute.cs" Link="Diagnostics\CodeAnalysis\CallerArgumentExpressionAttribute.cs" />
Expand Down

0 comments on commit 2d68abc

Please sign in to comment.