From ca708c8ece7490d980c88ebe12fc4a553b20b561 Mon Sep 17 00:00:00 2001 From: Dmitry Kryukov Date: Sun, 30 Jun 2024 22:37:38 +0300 Subject: [PATCH] Removed several collections which are updated, but seem to be never accessed. --- .../src/main/java/org/apache/jmeter/gui/HtmlReportUI.java | 6 ------ .../main/java/org/apache/jmeter/testelement/TestPlan.java | 4 ---- .../org/apache/jmeter/protocol/jms/sampler/JMSSampler.java | 3 --- 3 files changed, 13 deletions(-) diff --git a/src/core/src/main/java/org/apache/jmeter/gui/HtmlReportUI.java b/src/core/src/main/java/org/apache/jmeter/gui/HtmlReportUI.java index 4ff62a8f1e2..97b5a79bc62 100644 --- a/src/core/src/main/java/org/apache/jmeter/gui/HtmlReportUI.java +++ b/src/core/src/main/java/org/apache/jmeter/gui/HtmlReportUI.java @@ -52,7 +52,6 @@ import org.slf4j.LoggerFactory; public class HtmlReportUI implements ActionListener { - private static final Set commands = new HashSet<>(); private static final Logger LOGGER = LoggerFactory.getLogger(HtmlReportUI.class); private static final String CREATE_REQUEST = "CREATE_REQUEST"; @@ -82,11 +81,6 @@ public class HtmlReportUI implements ActionListener { private final ImageIcon inErrorIcon = JMeterUtils.getImage(IMAGES_PREFIX + iconSize +"/dialog-error-5.png");// $NON-NLS-1$ private final ImageIcon completedIcon = JMeterUtils.getImage(IMAGES_PREFIX + iconSize +"/task-complete.png");// $NON-NLS-1$ - - static { - commands.add(ActionNames.HTML_REPORT); - } - public HtmlReportUI() { super(); } diff --git a/src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java b/src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java index 0f19947ee28..82498960c93 100644 --- a/src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java +++ b/src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java @@ -43,8 +43,6 @@ public class TestPlan extends AbstractTestElement implements Serializable, TestS private static final String BASEDIR = "basedir"; - private transient List threadGroups = new ArrayList<>(); - // There's only 1 test plan, so can cache the mode here private static volatile boolean functionalMode = false; @@ -68,7 +66,6 @@ public TestPlanSchema getSchema() { // create transient item protected Object readResolve(){ - threadGroups = new ArrayList<>(); return this; } @@ -213,7 +210,6 @@ public void addTestElement(TestElement tg) { * the feature to be added to the AbstractThreadGroup attribute */ public void addThreadGroup(AbstractThreadGroup group) { - threadGroups.add(group); } /** diff --git a/src/protocol/jms/src/main/java/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java b/src/protocol/jms/src/main/java/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java index afa833b5cdb..1ea1d922869 100644 --- a/src/protocol/jms/src/main/java/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java +++ b/src/protocol/jms/src/main/java/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java @@ -254,7 +254,6 @@ private void handleOneWay(SampleResult res) throws JMSException { private void handleRead(JMeterContext context, SampleResult res) { LOGGER.debug("isRead"); - StringBuilder sb = new StringBuilder(75); res.setSuccessful(true); Sampler sampler = context.getPreviousSampler(); SampleResult sr = context.getPreviousResult(); @@ -273,8 +272,6 @@ private void handleRead(JMeterContext context, SampleResult res) { do { result = browseQueueForConsumption(sendQueue, jmsSelector, res, buffer, propBuffer); if (result != null) { - sb.append(result); - sb.append('\n'); sampleCounter++; } sampleTries++;