Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] Minor: Fix warnings and rename event handler better #7412

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[CORE] Minor: Fix warnings and rename event handler better #7412

merged 2 commits into from
Oct 8, 2024
+7 −8

Conversation

surnaik
Copy link
Contributor

@surnaik surnaik commented Oct 4, 2024 •
edited
Loading

What changes were proposed in this pull request?

Fixes import and renamed SQLExecutionEnd to proper name. Also refactors Gluten Build Info to remove warnings.

How was this patch tested?

CI

@github-actions github-actions bot added the CORE works for Gluten Core label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@surnaik
Copy link
Contributor Author

surnaik commented Oct 4, 2024

@zhztheplayer Please review, minor refactor to reflect the intention of event better

@surnaik surnaik changed the title [CORE] Minor: Refactor GlutenSQLAppStatusListener [CORE] Minor: Refactor files Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Run Gluten Clickhouse CI

@surnaik surnaik changed the title [CORE] Minor: Refactor files [CORE] Minor: Refactor files [1/n] Oct 4, 2024
@surnaik surnaik changed the title [CORE] Minor: Refactor files [1/n] [CORE] Minor: Fix warnings and rename event handler better Oct 4, 2024
@surnaik
Copy link
Contributor Author

surnaik commented Oct 4, 2024

Test failure is unrelated, please retry

@zhztheplayer zhztheplayer merged commit 02ac614 into apache:main Oct 8, 2024
48 checks passed
@surnaik
Copy link
Contributor Author

surnaik commented Oct 8, 2024

Thanks @zhztheplayer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhztheplayer zhztheplayer zhztheplayer approved these changes

Assignees
No one assigned
Labels
CORE works for Gluten Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surnaik @zhztheplayer