Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Minor: Fix documentation of flushable partial aggregate #7353

Merged
merged 10 commits into from
Sep 26, 2024
Merged

[VL] Minor: Fix documentation of flushable partial aggregate #7353

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
efda001
Always round negative decimals for integral types
surnaik Sep 24, 2024
a4e6bb5
Merge branch 'main' into decimal-fix
surnaik Sep 24, 2024
8e40092
Add more tests
surnaik Sep 24, 2024
2c159fc
Fix tests
surnaik Sep 25, 2024
b740283
Merge branch 'main' into decimal-fix
surnaik Sep 25, 2024
fab86f9
Fix tests
surnaik Sep 25, 2024
e7a7037
Merge branch 'main' into decimal-fix
surnaik Sep 25, 2024
6307220
Fix documentation
surnaik Sep 25, 2024
e07e1c6
Merge branch 'main' into decimal-fix
surnaik Sep 25, 2024
f566ad9
Fix documentation
surnaik Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1821,8 +1821,8 @@ object GlutenConfig {
buildConf("spark.gluten.sql.columnar.backend.velox.abandonPartialAggregationMinPct")
.internal()
.doc(
"If partial aggregation input rows number greater than this value, "
+ " partial aggregation may be early abandoned. Note: this option only works when " +
"If partial aggregation aggregationPct greater than this value, "
+ "partial aggregation may be early abandoned. Note: this option only works when " +
"flushable partial aggregation is enabled. Ignored when " +
"spark.gluten.sql.columnar.backend.velox.flushablePartialAggregation=false.")
.intConf
Expand All @@ -1832,8 +1832,8 @@ object GlutenConfig {
buildConf("spark.gluten.sql.columnar.backend.velox.abandonPartialAggregationMinRows")
.internal()
.doc(
"If partial aggregation aggregationPct greater than this value, "
+ "partial aggregation may be early abandoned. Note: this option only works when " +
"If partial aggregation input rows number greater than this value, "
+ " partial aggregation may be early abandoned. Note: this option only works when " +
"flushable partial aggregation is enabled. Ignored when " +
"spark.gluten.sql.columnar.backend.velox.flushablePartialAggregation=false.")
.intConf
Expand Down
Loading