Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Minor: Fix documentation of flushable partial aggregate #7353

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

surnaik
Copy link
Contributor

@surnaik surnaik commented Sep 25, 2024

What changes were proposed in this pull request?

The documentation of min partial aggregate rows and min partial aggregate pct to abandon was swapped. Minor fix to correct this.

@github-actions github-actions bot added the CORE works for Gluten Core label Sep 25, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@surnaik
Copy link
Contributor Author

surnaik commented Sep 25, 2024

@zhouyuan very small fix to correct the documentation

Copy link

Run Gluten Clickhouse CI

@surnaik
Copy link
Contributor Author

surnaik commented Sep 25, 2024

Unrelated failure

@surnaik
Copy link
Contributor Author

surnaik commented Sep 25, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhztheplayer zhztheplayer changed the title [MINOR] Fix Documentation of Flushable Partial Aggregate [MINOR] Fix documentation of flushable partial aggregate Sep 26, 2024
@zhztheplayer zhztheplayer changed the title [MINOR] Fix documentation of flushable partial aggregate [VL] Minor: Fix documentation of flushable partial aggregate Sep 26, 2024
@zhztheplayer zhztheplayer merged commit 9093e85 into apache:main Sep 26, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants