[VL] Follow-ups for #7304 #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
PHILO-HE
reviewed
Sep 25, 2024
| @@ -97,7 +98,7 @@ object SparkArrowUtil { | |||
| .map( | |||
| field => | |||
| toArrowField( | |||
| ConverterUtils.normalizeStructFieldName(field.name), | |||
| normalizeColName(field.name), | |||
There was a problem hiding this comment.
@zhztheplayer, looks normalizeColName is not equivalent to normalizeStructFieldName which makes the conversion disabled for CH backend.
There was a problem hiding this comment.
It seems gluten-arrow only used for velox backend.
There was a problem hiding this comment.
Yes. Let's keep gluten-arrow an individual module so future refactors can be made easier. Minor code duplications like this one will be acceptable.
PHILO-HE
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups for #7304
To keep the new module dependency graph defined in #7264.
cc @zml1206 @PHILO-HE