Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6876] Support Spark-352 #7138

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Sep 6, 2024

What changes were proposed in this pull request?

Support Spark 352

fixes #6876

How was this patch tested?

Pass GHA

@github-actions github-actions bot added CORE works for Gluten Core INFRA TOOLS labels Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

#6876

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

@@ -107,7 +107,7 @@ class ColumnarShuffleManager(conf: SparkConf) extends ShuffleManager with Loggin
metrics,
shuffleExecutorComponents)
case other: BaseShuffleHandle[K @unchecked, V @unchecked, _] =>
new SortShuffleWriter(other, mapId, context, shuffleExecutorComponents)
new SortShuffleWriter(other, mapId, context, _, shuffleExecutorComponents)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that gluten will not guarantee spark minor version compatibility?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wForget,
Not guaranteed for all minor versions indeed. Actually it's the same for Spark 32 & 3.3 & 3.4. It's only tested with the latest minor release.
The issue is mostly due to the shim layer design, and the CI/CD resources are also not enough for so many small versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thank you.

@zhouyuan zhouyuan marked this pull request as draft September 6, 2024 06:11
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

p: SparkPlan,
reason: String,
fallbackNodeToReason: mutable.HashMap[String, String]): Unit = {
p.getTagValue(QueryPlan.OP_ID_TAG).foreach {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-48610

QueryPlan.OP_ID_TAG doesn't exist in spark 3.5.2+ / 4.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there's also a minor change on sortshufflewriter, will move these changes to shim layer

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

github-actions bot commented Sep 9, 2024

Run Gluten Clickhouse CI

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Copy link

github-actions bot commented Oct 4, 2024

Run Gluten Clickhouse CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core INFRA TOOLS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Spark 352
3 participants