Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-9009] Fix potential race condition when listing files by leveraging exception type #12834

Merged

Conversation

the-other-tim-brown
Copy link
Contributor

Change Logs

  • Updates FSUtils#getAllDataFilesInPartition to return an empty list if a FileNotFoundException is thrown. Currently the code will do another check to see if the path exists but this exception type will only be thrown when the path does not exist. This can result in a potential race condition if there is another thread creating that directory. The FS API also states that it Throws: FileNotFoundException – when the path does not exist

Impact

  • Fixes exception thrown in flakey test Test Bulk Insert Into Consistent Hashing Bucket Index Table

Risk level (write none, low medium or high below)

Low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Feb 12, 2025
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan changed the title [MINOR] Fix potential race condition when listing files by leveraging exception type [HUDI-9009] Fix potential race condition when listing files by leveraging exception type Feb 13, 2025
@wombatu-kun wombatu-kun merged commit d1d2f7c into apache:master Feb 13, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS PR with lines of changes in <= 10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants