Skip to content

Pull Request Checklist

helix-bot edited this page Nov 10, 2022 · 8 revisions

Before you submit a pull request from your forked repo make sure that it meets these guidelines:

PR Description

Branch

  • update your fork of helix
  • rebase your feature branch with git rebase -i upstream/master
  • resolve all conflicts
  • git push --force from your feature branch to cleanly update your PR

Docs

After Creating PR

  • address reviewer comments and feedback.
  • Leave a final Github comment (example) on the PR in this format:
This PR is ready to be merged, approved by @reviewer  
Final commit message:
## <Final Commit Subject> (#<IssueNumber>)
<Final Commit Body>
  • git commit --allow-empty -m "<Your PR Title>" to create one final commit message that Github will use when it squashes your branch to create one squashed commit to be merged into master.

See also the helix 📝 PR Merge Steps

Tip

Put an "x" between brackets to mark the box checked in the markdown (e.g. [ ] -> [x])

Clone this wiki locally