-
Notifications
You must be signed in to change notification settings - Fork 228
Pull Request Checklist
helix-bot edited this page Nov 10, 2022
·
8 revisions
Before you submit a pull request from your forked repo make sure that it meets these guidelines:
- Find an existing helix issue or create a new helix issue.
- Mention the issue number in the PR description.
- If adding new functionality include unit tests, integration tests, or both.
- Include the result of
mvn test
command in your PR's description. See 📝 Pull Request Testing for details. - Make sure that your PR conforms to the 📝 Helix PR Template
- update your fork of helix
- rebase your feature branch with
git rebase -i upstream/master
- resolve all conflicts
-
git push --force
from your feature branch to cleanly update your PR
- Add an Apache License header to all new files
- If the pull request adds functionality, please add a new helix wiki page that details the motivation for and use of the new feature.
- address reviewer comments and feedback.
- Leave a final Github comment (example) on the PR in this format:
This PR is ready to be merged, approved by @reviewer
Final commit message:
## <Final Commit Subject> (#<IssueNumber>)
<Final Commit Body>
-
git commit --allow-empty -m "<Your PR Title>"
to create one final commit message that Github will use when it squashes your branch to create one squashed commit to be merged into master.
See also the helix 📝 PR Merge Steps
Put an "x" between brackets to mark the box checked in the markdown (e.g. [ ] -> [x]
)
Pull Request Description Template
ZooKeeper API module for Apache Helix
DataAccessor for Assignment Metadata
Concurrency and Parallelism for BucketDataAccessor
WAGED Rebalance Pipeline Redesign
WAGED rebalancer Hard Constraint Scope Expansion
IdealState Dependency Removal Progression Remove requested state in Task Framework