feat: supports nacos service discovery #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoghostCn
requested changes
Feb 26, 2025
pkg/adapter/dubboregistry/registry/nacos/application_listener.go
Outdated
Show resolved
Hide resolved
pkg/adapter/dubboregistry/registry/nacos/application_listener.go
Outdated
Show resolved
Hide resolved
pkg/adapter/dubboregistry/registry/nacos/application_service_listener.go
Show resolved
Hide resolved
|
add samples on https://github.com/apache/dubbo-go-pixiu-samples |
merge this PR firstly? |
Comment on lines
-169
to
+175
|
|
||
| go func(v *serviceInfo) { | ||
| defer l.wg.Done() | ||
| n.serviceInfoMap[key] = svcInfo | ||
|
|
||
| sub := &vo.SubscribeParam{ | ||
| ServiceName: getSubscribeName(url), | ||
| SubscribeCallback: l.Callback, | ||
| GroupName: z.regConf.Group, | ||
| } | ||
| sub := &vo.SubscribeParam{ | ||
| ServiceName: getSubscribeName(url), | ||
| SubscribeCallback: l.Callback, | ||
| GroupName: n.regConf.Group, | ||
| } | ||
|
|
||
| if err := z.client.Subscribe(sub); err != nil { | ||
| logger.Errorf("subscribe listener with interfaceKey = %s, error = %s", l, err) | ||
| } | ||
| }(svcInfo) | ||
| if err := n.client.Subscribe(sub); err != nil { | ||
| logger.Errorf("subscribe listener with interfaceKey = %s, error = %s", l, err) |
There was a problem hiding this comment.
why remove this goroutine
There was a problem hiding this comment.
Because the Subscribe is no-block func.
There is no need to keep the goroutine.
|
LGTM |
baerwang
reviewed
Mar 7, 2025
pkg/adapter/dubboregistry/registry/nacos/application_listener.go
Outdated
Show resolved
Hide resolved
|
Change this line to application, then testing can proceed.
|
mark4z
approved these changes
Mar 7, 2025
|
LGTM |
1 similar comment
|
LGTM |
|
No-SilverBullet
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
supports nacos service discovery
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Does this PR introduce a user-facing change?: