Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] DataFrame CSV Stream Load optimization #137

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

huanccwang
Copy link
Contributor

(csv格式)当datafram进行stream load时,若用户传了columns,则以传参为主,若没有传columns,则默认以df的schema进行隐式传参,这样的好处后续用户在对df进行streamload时,可以直接使用,而不用关心df的schema与底表是否相同。

@JNSimba
Copy link
Member

JNSimba commented Oct 17, 2023

Thank you for your contribution, please resolve the merge conflict

# Conflicts:
#	spark-doris-connector/src/main/java/org/apache/doris/spark/load/DorisStreamLoad.java
@JNSimba
Copy link
Member

JNSimba commented Oct 25, 2023

ci compilation failed, would you like to take a look?

@huanccwang
Copy link
Contributor Author

ci compilation failed, would you like to take a look?

done

# Conflicts:
#	spark-doris-connector/src/main/java/org/apache/doris/spark/load/DorisStreamLoad.java
@JNSimba JNSimba changed the title DataFrame CSV Stream Load 优化 [Improve] DataFrame CSV Stream Load optimization Nov 7, 2023
Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit a2e682b into apache:master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants