[feature] add stream load config to add double quotes for field when csv format. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfboys
reviewed
Jul 27, 2023
| FIELD_DELIMITER = EscapeHandler.escapeString(streamLoadProp.getOrDefault("column_separator", "\t")); | ||
| this.trimDoubleQuotes = Boolean.parseBoolean(streamLoadProp.getOrDefault("trim_double_quotes", "false")); |
|
Thank you for your contribution, this error means that the delimiter is -->, and then ---> is not recognized? |
yes，the problem occurs in the delimited implementation of CSVReader. |
gnehil
reviewed
Aug 29, 2023
| row.stream().map(field -> field == null ? NULL_VALUE : field.toString()) | ||
| .collect(Collectors.joining(FIELD_DELIMITER)) | ||
| ).collect(Collectors.joining(LINE_DELIMITER)); | ||
| if (addDoubleQuotes && trimDoubleQuotes) { |
There was a problem hiding this comment.
It looks like this feature only works if both add_double_quotes and trim_double_quotes are set to true. So is it necessary to enforce setting trim_double_quotes to true when add_double_quotes is true?
CodeCooker17
force-pushed
the
add_double_quotes
branch
2 times, most recently
from
df64983 to
5a2a72e
Compare
CodeCooker17
force-pushed
the
add_double_quotes
branch
from
5a2a72e to
5448717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…csv format.
Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
add config "add_double_quotes" Add double quotes to filed before streamload, combined with "trim_double_quotes" to prevent CsvReader from failing to split data when the last character of the field data is the same as the first character of the field separator
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...