Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] add label replace when label not meet the specifications #498

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

JNSimba
Copy link
Member

@JNSimba JNSimba commented Oct 11, 2024

Proposed changes

Issue Number: close #xxx

Problem Summary:

  1. When the table name is too long, the concatenated label will be greater than 128 characters.
  2. When the table name contains Chinese characters, it cannot be concatenated because the HTTP request header cannot contain Chinese characters.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

CalvinKirs
CalvinKirs previously approved these changes Oct 12, 2024
@JNSimba JNSimba marked this pull request as draft October 12, 2024 01:52
@JNSimba JNSimba marked this pull request as ready for review October 12, 2024 01:52
@JNSimba JNSimba merged commit 2f26c8f into apache:master Dec 4, 2024
6 checks passed
@JNSimba JNSimba mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants