Simplify FileSource::create_file_opener's signature
#14798
+36
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/simplify-create-file-opener
branch
from
eb80ee3 to
c049a69
Compare
AdamGS
force-pushed
the
adamg/simplify-create-file-opener
branch
from
c049a69 to
63a73e5
Compare
AdamGS
changed the title
FileSource::create_file_opener's signature
|
After some thought, I think removing the If we want to add more validation to parameters, IMO the place to add that is when we use |
alamb
approved these changes
Feb 21, 2025
| @@ -38,10 +38,10 @@ pub trait FileSource: Send + Sync { | |||
| /// Creates a `dyn FileOpener` based on given parameters | |||
| fn create_file_opener( | |||
| &self, | |||
| object_store: datafusion_common::Result<Arc<dyn ObjectStore>>, | |||
| object_store: Arc<dyn ObjectStore>, | |||
There was a problem hiding this comment.
I agree the old signature is very weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FileSource::create_file_openertakes aResultargument that is never used #14797 .Rationale for this change
Makes the interface slightly more idiomatic.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?