Add support for Dictionary to AST datatype in unparser
#14783
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
Dictionary to AST datatypeDictionary to AST datatype in unparser
|
Thanks @cetra3 @phillipleblanc do you have any suggestions about where we could test this one? |
cetra3
force-pushed
the
support_ast_dictionary_dtype
branch
from
d2c76df to
38c6e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue raised, just something we've seen in production
Rationale for this change
Ensures we can convert dictionary types to ast datatypes
What changes are included in this PR?
Adds a small change to support dictionaries
Are these changes tested?
I am actually not too sure how best to test this, might need a bit of guidance here if we wanna add a test
Are there any user-facing changes?
No