Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ts): Added a TS compilation check #589

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

breautek
Copy link
Contributor

Platforms affected

Motivation and Context

Adds a TS check on our type def files.

Description

Adds Typescript 5.1 as a dev dependency and updates the test script to run tsc to see if our types will at least compile.

There is an empty .ts file as an entry point for tsc, but it could be expanded in the future to actually make use of the API and ensure that types will compile as expected.

Testing

Ran npm test

Tests will fail without a PR fix such as #588

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 9.0.0 milestone Jul 28, 2023
@peitschie
Copy link
Contributor

This all makes sense to me! 🥇

types/tests/tsconfig.json Show resolved Hide resolved
types/tests/index.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants