Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(android) Update empty filename issue for supporting multiple images #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(android) Update empty filename issue for supporting multiple images #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/android/CameraLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,9 @@ private File createCaptureFile(int encodingType) {
*/
private File createCaptureFile(int encodingType, String fileName) {
if (fileName.isEmpty()) {
fileName = ".Pic";
//creating timestamps for empty filename to differentiate between multiple files selected via gallery
String timeStamp = new SimpleDateFormat(TIME_FORMAT).format(new Date());
fileName = timeStamp;
Comment on lines +338 to +340
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//creating timestamps for empty filename to differentiate between multiple files selected via gallery
String timeStamp = new SimpleDateFormat(TIME_FORMAT).format(new Date());
fileName = timeStamp;
// Append the current time in milliseconds for empty filename to differentiate between multiple files selected via gallery
fileName = ".Pic-" + System.currentTimeMillis();

IMO, I would suggest the above.

What you have might work to a certain point.

The TIME_FORMAT's lowest placement is in seconds.

Could someone take burst shots and therefore have many photos per second. Using System.currentTimeMillis might help out a bit since it's now in milliseconds.

Example filename with the above code would be: .Pic-1647402802991

I would not recommend updating the value of TIME_FORMAT. If changed, then the PR becomes a major breaking PR.

To keep or not to keep the ".Pic-" prefix is questionable? If it is kept as a prefix, then it could be used as a keyword filter when grabbing all files with the .Pic prefixed. I don't know if this is necessary, but I also don't know what other files exist in the same directory.

What do you think?

}

if (encodingType == JPEG) {
Expand Down