Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LANG-1682] Adding new startsWithAnyIgnoreCase method and tests cases #1040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laurentschoelens
Copy link
Contributor

Adding new method startsWithAnyIgnoreCase method for case-insensitive version of startsWithAny

@laurentschoelens laurentschoelens changed the title LANG-1682 : adding new startsWithAnyIgnoreCase method and tests cases [LANG-1682] Adding new startsWithAnyIgnoreCase method and tests cases Mar 14, 2023
@garydgregory
Copy link
Member

My preference is to stop adding APIs that are variations of other APIs based on the casing (and encoding and so on). In the longer term, I can see adding a new String utility class that tracks such an attribute on its instance such that you'd say something like Strings.caseSensitive().someOperation(...) and Strings.caseInsensitive().someOperation(...).

@laurentschoelens
Copy link
Contributor Author

Thanks for the reply.
Is there any plans for this ? It's huge refactoring.

@garydgregory
Copy link
Member

It's something I'd like to do and might take a swing at when I am on vacation in April...

@laurentschoelens
Copy link
Contributor Author

Like you expose the calling to this new Strings class, it looks like you're creating new instance (like a builder) and that should lead to memory impact and performances issues (as I see it)

@laurentschoelens
Copy link
Contributor Author

Like you expose the calling to this new Strings class, it looks like you're creating new instance (like a builder) and that should lead to memory impact and performances issues (as I see it)

If not, this could lead to thread-safety issues. But again I don't know what you want to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants