Full support of aws-secret-manager

[JiriOndrusek]

fixes #6673, #6952

Aws-secret-manager native profile is added.
Tests are moved into aws2-groupped module.
Test coverage is extended to cover credentialsProvider and missing headers.

[jamesnetherton]

Tests failed:

java.lang.IllegalArgumentException: Error configuring property: camel.component.aws-cw.secret-key because cannot find component with name aws-cw. Make sure you have the component on the classpath

[JiriOndrusek]

Tests failed:

java.lang.IllegalArgumentException: Error configuring property: camel.component.aws-cw.secret-key because cannot find component with name aws-cw. Make sure you have the component on the classpath

I'll check that

[JiriOndrusek]

That is my fault, I changed something in aws-test-support, let me fix it

[JiriOndrusek]

I missed some hardcoded aws2-*. It is fixed now.

[aldettinger]

Few nitpicks, looks good beyound.

Maybe there is need for more coverage like auto reload in other prs.

[JiriOndrusek]

Maybe there is need for more coverage like auto reload in other prs.

Do you mean a use case with context reload? it is covered by different test class, which already exists (see https://github.com/apache/camel-quarkus/blob/main/integration-tests-jvm/aws-secrets-manager/src/test/java/org/apache/camel/quarkus/component/aws/secrets/manager/it/CamelContextRefreshOnSecretRefreshTest.java)

[JiriOndrusek]

failure in saga example seems to be unrelated

[aldettinger]

Maybe there is need for more coverage like auto reload in other prs.

Do you mean a use case with context reload? it is covered by different test class, which already exists (see https://github.com/apache/camel-quarkus/blob/main/integration-tests-jvm/aws-secrets-manager/src/test/java/org/apache/camel/quarkus/component/aws/secrets/manager/it/CamelContextRefreshOnSecretRefreshTest.java)

Yes, more generally the question is whether all features mentioned in the camel documentation are covered with tests ;)

[JiriOndrusek]

Yes, more generally the question is whether all features mentioned in the camel documentation are covered with tests ;)

That is a valid question, I'm currently adding test coverage into azure-key-vault and I noticed feature related to context refresh, which might not be covered fully in aws. I'm switching to draft and wI'll revisit this PR again once azure one is done.

[aldettinger]

Yes, more generally the question is whether all features mentioned in the camel documentation are covered with tests ;)

That is a valid question, I'm currently adding test coverage into azure-key-vault and I noticed feature related to context refresh, which might not be covered fully in aws. I'm switching to draft and wI'll revisit this PR again once azure one is done.

@JiriOndrusek This great pr already add a lot of value. Follow ups could be other prs. WDYT ?

[JiriOndrusek]

Yes, more generally the question is whether all features mentioned in the camel documentation are covered with tests ;)

That is a valid question, I'm currently adding test coverage into azure-key-vault and I noticed feature related to context refresh, which might not be covered fully in aws. I'm switching to draft and wI'll revisit this PR again once azure one is done.

@JiriOndrusek This great pr already add a lot of value. Follow ups could be other prs. WDYT ?

That's right. Let's merge this one and if anything is missing (which I'm not sure at the moment, as I discovered that the feature I thought about is covered), a new PR can be added.