Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6569] RelToSqlConverter missing IGNORE NULLS for window func… #3957

Merged
merged 1 commit into from
Sep 15, 2024
Merged

[CALCITE-6569] RelToSqlConverter missing IGNORE NULLS for window func… #3957

merged 1 commit into from
Sep 15, 2024

Conversation

JiajunBernoulli
Copy link
Contributor

…tion

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

YiwenWu
YiwenWu approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@YiwenWu YiwenWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caicancai
caicancai approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

suibianwanwank
suibianwanwank approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@suibianwanwank suibianwanwank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiajunBernoulli JiajunBernoulli added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Sep 13, 2024
@mihaibudiu mihaibudiu merged commit 644e29f into apache:main Sep 15, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suibianwanwank suibianwanwank suibianwanwank approved these changes

@caicancai caicancai caicancai approved these changes

@mihaibudiu mihaibudiu mihaibudiu approved these changes

@YiwenWu YiwenWu YiwenWu approved these changes

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JiajunBernoulli @YiwenWu @mihaibudiu @caicancai @suibianwanwank