-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-6566] JDBC adapter should generate PI function with parenthe… #3956
Conversation
@@ -1815,7 +1815,7 @@ public class SqlStdOperatorTable extends ReflectiveSqlOperatorTable { | |||
|
|||
/** The {@code PI} function. */ | |||
public static final SqlFunction PI = | |||
SqlBasicFunction.create("PI", ReturnTypes.DOUBLE, OperandTypes.NILADIC, | |||
SqlBasicFunction.create(SqlKind.PI, ReturnTypes.DOUBLE, OperandTypes.NILADIC, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to be changed to SqlKind.PI?
The others look good
Based on the discussion in jira, is there a more general way to implement this rather than being specific to |
@YiwenWu @caicancai Thanks for the review. We can discuss this in Jira. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I will merge this PR in the next 48 hours if there are no more comments. |
…ses in most dialects
…ses When unparse PI function without parentheses