Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-6566] JDBC adapter should generate PI function with parenthe… #3956

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

NobiGo
Copy link
Contributor

@NobiGo NobiGo commented Sep 10, 2024

…ses When unparse PI function without parentheses

@@ -1815,7 +1815,7 @@ public class SqlStdOperatorTable extends ReflectiveSqlOperatorTable {

/** The {@code PI} function. */
public static final SqlFunction PI =
SqlBasicFunction.create("PI", ReturnTypes.DOUBLE, OperandTypes.NILADIC,
SqlBasicFunction.create(SqlKind.PI, ReturnTypes.DOUBLE, OperandTypes.NILADIC,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be changed to SqlKind.PI?
The others look good

@YiwenWu
Copy link
Contributor

YiwenWu commented Sep 12, 2024

Based on the discussion in jira, is there a more general way to implement this rather than being specific to PI functions?

@NobiGo
Copy link
Contributor Author

NobiGo commented Sep 13, 2024

Based on the discussion in jira, is there a more general way to implement this rather than being specific to PI functions?

@YiwenWu @caicancai Thanks for the review. We can discuss this in Jira.

Copy link
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@NobiGo
Copy link
Contributor Author

NobiGo commented Dec 9, 2024

I will merge this PR in the next 48 hours if there are no more comments.

@NobiGo NobiGo merged commit cd0b8da into apache:main Dec 11, 2024
17 of 18 checks passed
@NobiGo NobiGo deleted the CALCITE-6566 branch December 18, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants