Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6549] Add LOG1P function (enabled in Spark library) #3955

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[CALCITE-6549] Add LOG1P function (enabled in Spark library) #3955

merged 1 commit into from
Sep 13, 2024

Conversation

caicancai
Copy link
Member

No description provided.

YiwenWu
YiwenWu approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@YiwenWu YiwenWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NobiGo NobiGo added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Sep 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@caicancai
Copy link
Member Author

@NobiGo Hi, Is it convenient to merge? #3954 I plan to push this PR merge next week. I am currently testing it, and it may cause some conflicts at that time.

@NobiGo NobiGo merged commit 91fe118 into apache:main Sep 13, 2024
30 of 35 checks passed
@caicancai caicancai deleted the 6549 branch September 16, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobiGo NobiGo NobiGo approved these changes

@YiwenWu YiwenWu YiwenWu approved these changes

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caicancai @YiwenWu @NobiGo