[CALCITE-6559] Query with measure that applies AVG to SMALLINT throws AssertionError "Cannot add expression of different type to set" #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a query has a measure that is AVG applied to a SMALLINT or TINYINT column, we get the following assertion failure: java.lang.AssertionError: Cannot add expression of different type to set: set type is RecordType(VARCHAR(9) JOB, MEASURE<SMALLINT NOT NULL> NOT NULL $f1, SMALLINT $f0) NOT NULL expression type is RecordType(VARCHAR(9) JOB, MEASURE<SMALLINT NOT NULL> NOT NULL $f1, SMALLINT NOT NULL $f0) NOT NULL The problem is that a cast is added internally to the result of SUM / COUNT, but this cast prevents a cast to nullable for the null-generating side of the outer join. (The outer join comes from the expansion of the measure as a correlated scalar subquery.) Close apache/calcite#xxxx
mihaibudiu
approved these changes
Sep 5, 2024
|
|
||
| !ok | ||
|
|
||
| !if (false) { |
There was a problem hiding this comment.
Is there an issue filed for this other problem?
There was a problem hiding this comment.
|
@amarkowitz, PTAL |
amarkowitz
reviewed
Sep 5, 2024
| @@ -179,6 +179,53 @@ from empm; | |||
|
|
|||
| !ok | |||
|
|
|||
| # [CALCITE-6559] LogicalCorrelate Type mismatch | |||
| # Occurs when AVG measure is applied to SMALLINT or TINYINT column. | |||
| # A CAST is added internally to the result of SUM / COUNT, but this cast | |||
There was a problem hiding this comment.
It's difficult to tell from this comment whether this was the cause of the bug or whether this is the new expectation after fixing. Have you considered moving this comment to CALCITE-6559 instead?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.