Casts between time intervals do not require scaling

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
apache · Jan 9, 2025 · 129e5cc · 129e5cc
1 parent d6e4cc4
commit 129e5cc
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java b/core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
@@ -1223,7 +1223,10 @@ private static Expression scaleValue(
           sourceType.getSqlTypeName().getEndUnit().multiplier;
       return RexImpTable.multiplyDivide(operand, multiplier, divider);
     }
-    if (SqlTypeName.INTERVAL_TYPES.contains(targetType.getSqlTypeName())) {
+    if (SqlTypeName.INTERVAL_TYPES.contains(targetType.getSqlTypeName())
+        && !SqlTypeName.INTERVAL_TYPES.contains(sourceType.getSqlTypeName())) {
+      // Conversion between intervals is only allowed if the intervals have the same type,
+      // and then it should be a no-op.
       final BigDecimal multiplier = targetType.getSqlTypeName().getEndUnit().multiplier;
       final BigDecimal divider = BigDecimal.ONE;
       return RexImpTable.multiplyDivide(operand, multiplier, divider);