improve registerMetric in orderExecutor #4393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhangjian
reviewed
May 27, 2024
| if (thread instanceof SingleThreadExecutor) { | ||
| ste = (SingleThreadExecutor) thread; | ||
| SingleThreadExecutor ste = (SingleThreadExecutor) thread; | ||
| ste.registerMetrics(statsLogger, name, i); |
There was a problem hiding this comment.
Did you change this like @hangc0276 commented? #4374 (comment)
If we can move registry in here, I think we can change createSingleThreadExecutor to return SingleThreadExecutor directly. Like I saiy in #4374 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue: #4373
Motivation
As is shown in the issue, This is the second pr to improve the registerMetric() in orderExecutor.
Changes
before :
after improvement, the metric is :